Skip to content

feat: add support for comments in forms#3329

Open
Chartman123 wants to merge 1 commit into
mainfrom
enh/comments
Open

feat: add support for comments in forms#3329
Chartman123 wants to merge 1 commit into
mainfrom
enh/comments

Conversation

@Chartman123
Copy link
Copy Markdown
Collaborator

This closes #1655 by integrating the comments app.

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added enhancement New feature or request php PHP related ticket javascript Javascript related ticket labels May 11, 2026
@Chartman123 Chartman123 requested a review from pringelmann May 11, 2026 20:57
@Chartman123 Chartman123 added integration Compatibility with other apps/systems 2. developing Work in progress labels May 11, 2026
@Chartman123 Chartman123 added this to the 5.3 milestone May 11, 2026
@Chartman123 Chartman123 added the 3. to review Waiting for reviews label May 11, 2026
@Chartman123 Chartman123 self-assigned this May 11, 2026
@Chartman123 Chartman123 requested a review from susnux May 11, 2026 20:57
@Chartman123 Chartman123 force-pushed the enh/comments branch 7 times, most recently from 12754de to abafef8 Compare May 11, 2026 21:55
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

@Chartman123 Chartman123 force-pushed the enh/comments branch 3 times, most recently from d93d465 to 69a4fc3 Compare May 11, 2026 22:23
@Chartman123 Chartman123 marked this pull request as ready for review May 11, 2026 22:32
@Chartman123
Copy link
Copy Markdown
Collaborator Author

Front-end code was created with assistance by Copilot. There's probably room for improvement.

I'm also facing the problem that sometimes the comments tab loads, but doesn't show existing comments. Probably some kind of race condition.

Comment thread lib/Controller/PageController.php
Comment thread lib/Listener/CommentsEntityListener.php
@pringelmann
Copy link
Copy Markdown
Collaborator

Should we also clean up comments when a form is deleted? (deleteForm() in FormMapper.php) Otherwise it will likely lead to many of orphan table rows over time

@Chartman123 Chartman123 removed the 2. developing Work in progress label May 17, 2026
@Chartman123 Chartman123 force-pushed the enh/comments branch 3 times, most recently from 85c968b to b4f7da2 Compare May 17, 2026 18:27
@Chartman123
Copy link
Copy Markdown
Collaborator Author

Fixed the review comments now :)

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request integration Compatibility with other apps/systems javascript Javascript related ticket php PHP related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to add Comment section for user (like polls)

3 participants