Conversation
Koc
force-pushed
the
feature/chunked-file-upload
branch
2 times, most recently
from
September 14, 2026 18:13
13e382e to
a7c89d1
Compare
Koc
force-pushed
the
feature/chunked-file-upload
branch
from
September 26, 2026 22:41
fa30648 to
a21d58d
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/chunked-file-upload
branch
from
September 28, 2026 09:02
a21d58d to
78099e0
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/chunked-file-upload
branch
from
September 28, 2026 12:40
78099e0 to
477a45f
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Koc
marked this pull request as ready for review
September 28, 2026 13:32
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/chunked-file-upload
branch
from
September 28, 2026 13:36
8733e08 to
9101ab5
Compare
Chartman123
reviewed
Sep 28, 2026
Chartman123
left a comment
Collaborator
There was a problem hiding this comment.
Two quick changes that came into my mind while watching the video :) I think "assembling" is too technical here for most users.
| <div v-if="activeUpload.assembling" class="upload-status"> | ||
| <progress | ||
| :aria-label=" | ||
| t('forms', 'Assembling file {fileName}', { |
Collaborator
There was a problem hiding this comment.
Suggested change
| t('forms', 'Assembling file {fileName}', { | |
| t('forms', 'Finishing upload for file {fileName}', { |
| fileName: activeUpload.name, | ||
| }) | ||
| " /> | ||
| {{ t('forms', 'Assembling file …') }} |
Collaborator
There was a problem hiding this comment.
Also no space before the ellipsis
Suggested change
| {{ t('forms', 'Assembling file …') }} | |
| {{ t('forms', 'Finishing upload…') }} |
Collaborator
Author
|
@Chartman123 I agree with you, but this terminology comes from the original library. Should we stay consistent in naming? |
Collaborator
I've asked the designers :) |
susnux
reviewed
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3449.
🎥 Demo
nextcloud-chunk-upload-2026-09-28_15.26.13.mp4
What changed
File question uploads previously used a single multipart
POSTrequest perselection. Files were limited by PHP upload limits and not paralleled. Also now we're displaying progressbar during upload.
Uploads now go through a temporary public upload share and the standard
Nextcloud WebDAV endpoint, the same mechanism used by the Files app:
POST .../submissions/files/{questionId}/sharecreates a temporary folderin the form owner's storage and shares it via a create-only (file drop)
public link.
public.php/davusing the uploader from@nextcloud/files(MKCOL workspace, parallel chunk PUTs, MOVE assemble).Chunking requires the
dav.public_shares_chunkingcapability; smallerfiles are sent as a plain PUT.
POST .../submissions/files/{questionId}/registerbinds the uploaded fileto the form and question and returns
uploadedFileId+uploadToken,which are submitted as the answer exactly as before.
Behavior changes
CleanupUploadedFilesJob.API
Two new endpoints (see
docs/API_v3.md/openapi.json):POST /api/v3/forms/{formId}/submissions/files/{questionId}/sharePOST /api/v3/forms/{formId}/submissions/files/{questionId}/registerThe existing
POST .../files/{questionId}multipart endpoint is unchangedand remains supported.
Dependencies
@nextcloud/files^4.1.0(new uploader, public chunking support)@nextcloud/vue^9.12.0How to test
via a public share link.
is shown and the submission succeeds.
upload in progress.
multipart fallback still works.
🤖 AI (if applicable)