Repository navigation
fix: remove submissionId from initial state - #3751
Conversation
fef6517 to
e54f4cd
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Chartman123
changed the title
Koc
left a comment
Koc
left a comment
There was a problem hiding this comment.
Wow, interesting. Can you share reproducer steps?
Yes sure, I clicked on edit submission in the results view. Than changed one answer and went to some other form to test your grid pr for (re) storing the answers to/from local storage. Then I saw that the changes were gone again and the original values were loaded. When I then went to some other forms submit view I saw the call to get the submissions of the previous form in the network tab. |
…rontend after editing a submission Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
e54f4cd to
88bd7c9
Compare
|
@Koc I found and fixed another bug. Now submissions loaded from the backend will be added to local storage. Until now only questions that have been updated got written there. Please review again :) |
|
Looks good from code perspective side. But I haven't tested it manually. But I trust you 🤝 😄 |
|
/backport to stable5.4 |
backportbot
Bot
removed
the
backport-request
2 participants
This fixes a stale submission id causing to load submission data in submit view even if you wouldn't expect it.
🤖 AI (if applicable)