Conversation
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
enjeck
marked this pull request as ready for review
June 25, 2025 18:57
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
Contributor
Author
|
I added a checkbox setting that lets one select whether to show the last viewed note or welcome screen when /index.php/apps/notes/ is visited: |
JuliaKirschenheuter
approved these changes
Jul 23, 2025
karlitschek
requested review from
JuliaKirschenheuter
and
a lite review from Copilot
August 6, 2026 12:17
There was a problem hiding this comment.
Pull request overview
Adds a new user setting to control what the Notes app shows on startup, intended to mitigate the privacy concern of automatically opening the last viewed note.
Changes:
- Add a new “Startup” setting in the app settings UI to toggle loading the last viewed note on launch.
- Adjust initial routing behavior in
App.vueto either open the last viewed note or the welcome screen based on the setting. - Introduce the new
loadRecentOnStartUpsetting (defaulttrue) in the backend settings service.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/components/AppSettings.vue | Adds the new startup setting UI and (currently) an extra unused handler method. |
| src/App.vue | Changes routing on note-load based on the new startup setting. |
| lib/Service/SettingsService.php | Registers the new setting and its validation/default behavior server-side. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+141
to
+145
| if (store.state.app.settings?.loadRecentOnStartUp) { | ||
| this.routeDefault(data.lastViewedNote) | ||
| } else { | ||
| this.routeWelcome() | ||
| } |
Comment on lines
+37
to
+41
| <NcAppSettingsSection id="start-up-section" :name="t('notes', 'Start Up')"> | ||
| <NcCheckboxRadioSwitch :checked.sync="settings.loadRecentOnStartUp" @update:checked="onChangeSettings"> | ||
| Load recently updated note on startup | ||
| </NcCheckboxRadioSwitch> | ||
| </NcAppSettingsSection> |
Comment on lines
+202
to
+211
| onChangeStartUp(event) { | ||
| this.saving = true | ||
| this.settings.loadRecentOnStartUp = event.target.checked | ||
| return setSettings(this.settings) | ||
| .catch(() => { | ||
| }) | ||
| .then(() => { | ||
| this.saving = false | ||
| }) | ||
| }, |
| @click="onChangeNotePath" | ||
| > | ||
| </NcAppSettingsSection> | ||
| <NcAppSettingsSection id="start-up-section" :name="t('notes', 'Start Up')"> |
Comment on lines
+73
to
+75
| 'validate' => function ($value) { | ||
| return $value === 'true' || $value === true; | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #955