Fix/point size lod snap - #37
Merged
Merged
Conversation
During camera interaction the viewer renders a coarse LOD pass that serves large world-space octree centroid splats, then a delayed fine pass replaces them with the smaller per-point sizes. With the previous parameters the splats were noticeably larger than the final points and lingered for up to a second, so points appeared too large and then snapped back to normal size. - point_cloud.h: raise the coarse-pass LOD fudge_factor from 0.25 to 0.5 so the octree descends deeper during interaction (smaller centroid splats, smaller size discontinuity vs. the fine pass) - viewer.h: shorten the fine-render debounce after wheel-zoom (500ms -> 100ms) and window expose (1000ms -> 200ms) so corrected sizes appear promptly
Release the query_point() screen-picking feature (already on master) together with the interactive point-size fix. Also brings setup.py and docs/source/conf.py up from a stale 0.1.1 so every version location agrees with pyproject.toml and pptk.__version__ (enforced by tests/test_build.py::test_pyproject_version_matches_pptk).
uv build runs CMake automatically via the setuptools build_ext, so the manual "configure _cmake_build, then uv build" steps were unnecessary. - document the single-command build (uv build) and that it's what CI runs - warn against running build/install commands from inside _cmake_build/ (a stale copied setup.py there produces a broken, mis-versioned build) - document the PPTK_FORCE_CMAKE=1 force-rebuild escape hatch (setup.py skips cmake when artifacts already exist) - add an editable dev-install section and a fast single-target rebuild loop - add libgl1-mesa-dev to the apt deps (the release CI installs it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.