update numDivergences in sampler_NUTS - #81
Closed
paciorek wants to merge 1 commit into
Closed
Conversation
Merged
Member
|
Closing this PR. Instead, changes are made in PR #82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so we have a PR for this work.
@danielturek are you up for carrying this forward to release when you have a chance this summer?
In conversation with me @perrydv mentioned that he wanted one of us to carefully check if the counting was being correctly done in terms of the levels of the tree-splitting, so perhaps you can do a careful code review.