Add Ruby 4, truffle ruby and jruby to build#167
Merged
Conversation
Owner
|
Looks like truffleruby works but jruby needs some fixes. |
Contributor
Author
|
@njh I've added another commit to fix the tests. Jruby had some issues with the test suite (so I've fixed that up) but the runtime code works perfectly. |
Owner
|
Thank you for doing this; looks like something is still failing though. |
Owner
|
Truffleruby: |
There was only one issue with the test suite, that on jruby TCPServer.new cannot be given a nil port, it must be an integer. However passing 0 should have the same effect on both cruby and jruby.
Contributor
Author
|
Unfortunately new releases of truffleruby and jruby seem to break things, but I've pinned down the versions and that has helped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to be sure that mqtt works with high performance runtimes like jruby and truffleruby. If there are any test failures I’ll look at fixing those up.
I’ve also replaced Ruby 3.5 with Ruby 4.0 as Ruby 3.5 was renamed to 4.0