src: migrate deprecated c-ares APIs to modern replacements

[omghante]

This PR migrates the deprecated c-ares reply-parsing APIs in src/cares_wrap.cc to the modern ares_dns_parse / ares_dns_record_t API family, replacing ~10 deprecated call sites (ares_parse_a_reply, ares_parse_aaaa_reply, ares_parse_ns_reply, ares_parse_ptr_reply, ares_parse_mx_reply, ares_parse_caa_reply, ares_parse_txt_reply_ext, ares_parse_srv_reply, ares_parse_naptr_reply, ares_parse_soa_reply) with their modern equivalents while preserving CNAME-TTL clamping behavior.

The server management functions (EnsureServers, GetServers, SetServers) retain the original ares_get_servers_ports / ares_set_servers_ports APIs with targeted pragma suppression, as the modern CSV alternatives (ares_get_servers_csv, ares_set_servers_ports_csv) silently drop IPv6 link-local addresses.

Fixes: #52464

[nodejs-github-bot]

Review requested:

• @nodejs/net

[codecov]

Codecov Report

❌ Patch coverage is 65.61265% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.64%. Comparing base (5e61a07) to head (3616cdb).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/cares_wrap.cc	65.61%	49 Missing and 38 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62724      +/-   ##
==========================================
- Coverage   89.65%   89.64%   -0.01%     
==========================================
  Files         712      712              
  Lines      220498   220595      +97     
  Branches    42278    42305      +27     
==========================================
+ Hits       197683   197758      +75     
- Misses      14663    14675      +12     
- Partials     8152     8162      +10     

Files with missing lines	Coverage Δ
src/cares_wrap.cc	61.86% <65.61%> (+0.21%)	⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

CI is very red

[omghante]

Thanks @mcollina! Fixed, all workflows are finally back to green! Feel free to take a look whenever you have a chance.

[omghante]

@mcollina I've reworked the approach now just suppressing the warnings with compiler pragmas instead of migrating APIs. Test file is fully untouched, all fe80:: cases preserved. Full API migration will be a follow-up PR.

[thisalihassan]

Signed-off-by is missing, can you please ammend your commit?

[omghante]

@thisalihassan Great catches, all valid. I've force-pushed a new approach just pragma-based warning suppression (13 lines, 1 file). No API migration, so the IPv6 link-local and CNAME-TTL clamping issues are gone. Signed-off-by added. Full migration can be a separate PR.

[omghante]

Hi @mcollina following up on this. I've addressed all feedback from your
earlier review and @thisalihassan's comments:

• Reworked to a pragma-based warning suppression approach (13 lines, 1 file)
  instead of a full API migration, avoiding the IPv6 link-local and CNAME-TTL
  clamping regressions
• Signed-off-by added
• CI is green

The full migration to ares_dns_parse / ares_get_servers_csv /
ares_set_servers_csv will be a separate follow-up PR as discussed.

Could you dismiss the "changes requested" state and re-review when you get
a chance? Thank you!

@targos this addresses the deprecation warnings you reported in #52464.

[mcollina]

lgtm

[targos]

This change doesn’t help

[omghante]

@targos Thanks for the feedback reworked! The PR now fully migrates all reply-parser APIs to ares_dns_parse; only the 3 server-management calls retain pragmas since the CSV replacements drop IPv6 link-local addresses.