util: create hex style cache and fast path#62999
Open
araujogui wants to merge 4 commits intonodejs:mainfrom
Open
util: create hex style cache and fast path#62999araujogui wants to merge 4 commits intonodejs:mainfrom
araujogui wants to merge 4 commits intonodejs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves util.styleText() performance for hex colors by introducing a cached hex-style lookup and a fast path for the common case where validateStream: false.
Changes:
- Add a module-level
hexStyleCacheand helper (getHexStyle) to memoize computed ANSI sequences for#RGB/#RRGGBB. - Reuse a shared close sequence constant for 24-bit foreground colors (
\u001b[39m) and integrate hex handling into thevalidateStream: falsefast path. - Refactor hex handling in the main formatting loop to use cached sequences instead of re-parsing on every call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62999 +/- ##
=======================================
Coverage 90.03% 90.04%
=======================================
Files 713 713
Lines 224950 225001 +51
Branches 42532 42543 +11
=======================================
+ Hits 202542 202598 +56
- Misses 14175 14185 +10
+ Partials 8233 8218 -15
🚀 New features to boost your workflow:
|
Renegade334
reviewed
Apr 29, 2026
c879174 to
521eba3
Compare
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
521eba3 to
5b9ea9d
Compare
Member
Author
|
CC @nodejs/performance |
gurgunday
requested changes
May 9, 2026
Member
gurgunday
left a comment
There was a problem hiding this comment.
This cache will grow indefinitely
I don't think we should land like this
49fe099 to
f4f71de
Compare
gurgunday
approved these changes
May 10, 2026
Member
gurgunday
left a comment
There was a problem hiding this comment.
code lgtm
note: i am unfamiliar with how much this is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve
styleTextperformance by caching and fast-pathBenchmark