Skip to content

deps: add missing static linking targets for libffi#63168

Open
ShogunPanda wants to merge 5 commits intonodejs:mainfrom
ShogunPanda:ffi-missing-static-archs
Open

deps: add missing static linking targets for libffi#63168
ShogunPanda wants to merge 5 commits intonodejs:mainfrom
ShogunPanda:ffi-missing-static-archs

Conversation

@ShogunPanda
Copy link
Copy Markdown
Contributor

This ensures static linking of libffi wherever it is supported.

@ShogunPanda ShogunPanda requested review from addaleax, bengl and mcollina May 7, 2026 13:20
@ShogunPanda ShogunPanda added the ffi Issues and PRs related to experimental Foreign Function Interface support. label May 7, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/ffi
  • @nodejs/gyp
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels May 7, 2026
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.04%. Comparing base (facd71e) to head (5b074f0).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/ffi/types.cc 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63168   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files         713      713           
  Lines      224950   224950           
  Branches    42530    42532    +2     
=======================================
+ Hits       202548   202555    +7     
+ Misses      14188    14173   -15     
- Partials     8214     8222    +8     
Files with missing lines Coverage Δ
src/ffi/types.cc 48.91% <50.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread doc/api/ffi.md Outdated
Comment thread deps/libffi/src/s390/sysv.S
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
@ShogunPanda ShogunPanda force-pushed the ffi-missing-static-archs branch from 8231062 to 5b074f0 Compare May 10, 2026 05:50
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants