deps: add missing static linking targets for libffi#63168
Open
ShogunPanda wants to merge 5 commits intonodejs:mainfrom
Open
deps: add missing static linking targets for libffi#63168ShogunPanda wants to merge 5 commits intonodejs:mainfrom
ShogunPanda wants to merge 5 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
anonrig
approved these changes
May 7, 2026
Collaborator
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63168 +/- ##
=======================================
Coverage 90.04% 90.04%
=======================================
Files 713 713
Lines 224950 224950
Branches 42530 42532 +2
=======================================
+ Hits 202548 202555 +7
+ Misses 14188 14173 -15
- Partials 8214 8222 +8
🚀 New features to boost your workflow:
|
aduh95
reviewed
May 8, 2026
aduh95
reviewed
May 8, 2026
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
8231062 to
5b074f0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures static linking of libffi wherever it is supported.