test: gc before test-memory-usage baseline#63214
Closed
inoway46 wants to merge 1 commit intonodejs:mainfrom
Closed
test: gc before test-memory-usage baseline#63214inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
49474c3 to
b83d76c
Compare
Collaborator
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63214 +/- ##
==========================================
- Coverage 90.03% 90.03% -0.01%
==========================================
Files 713 713
Lines 224950 224950
Branches 42532 42537 +5
==========================================
- Hits 202542 202535 -7
- Misses 14175 14186 +11
+ Partials 8233 8229 -4 π New features to boost your workflow:
|
Contributor
Author
|
It looks like this change was not sufficient to fully fix the flaky failure. The fedora-latest-x64 run failed on the same exact-size assertion: https://ci.nodejs.org/job/node-test-commit-linux/69926/nodes=fedora-latest-x64/ |
Contributor
Author
|
Closing this since the GC-before-baseline approach still failed in CI. I'll try relaxing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call gc() before taking the test-memory-usage baseline so stale ArrayBuffer backing stores are cleared before the strict delta check.
This keeps the exact 10 MiB assertion while avoiding unrelated cleanup between snapshots.
Fixes: #63210