test_runner: add parentId to test events with testId#63435
Open
MoLow wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
atlowChemi
approved these changes
May 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63435 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 714 714
Lines 225876 225926 +50
Branches 42737 42739 +2
=======================================
+ Hits 203408 203466 +58
- Misses 14244 14250 +6
+ Partials 8224 8210 -14
🚀 New features to boost your workflow:
|
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
a894092 to
548f144
Compare
atlowChemi
approved these changes
May 20, 2026
benjamingr
approved these changes
May 20, 2026
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
parentIdto thetest:enqueue,test:dequeue,test:start,test:complete,test:pass, andtest:failevent payloads. It carriesthe enclosing test's
testId(orundefinedfor top-level tests).Custom reporters need explicit parent linkage to track lineage when
concurrent siblings at the same nesting level interleave their events —
a shared ancestors stack records the wrong parent for every failing leaf
under siblings whose bodies yield before calling
t.test(), and theoutput tree collapses them to one entry.