fix: remove darwin.apple_sdk.frameworks.AppKit reference - #97
Merged
Merged
Conversation
nixpkgs removed the legacy darwin.apple_sdk attribute set (and apple_sdk_11_0/apple_sdk_12_3) in NixOS/nixpkgs#429387, replacing it with a throwing stub. Any nixpkgs revision after that PR (merged 2025-08-16) fails to evaluate this flake on *-darwin systems: error: darwin.apple_sdk_11_0 has been removed as it was a legacy compatibility stub; see <https://nixos.org/manual/nixpkgs/stable/#sec-darwin-legacy-frameworks> for migration instructions Per the migration notes, the default SDK now provides AppKit without an explicit buildInput, so the reference can simply be dropped. Verified: nix build .#default succeeds on aarch64-darwin with this change.
willcforte
changed the title
darwin.apple_sdk.frameworks.AppKit
willcforte
changed the title
darwin.apple_sdk.frameworks.AppKitdarwin.apple_sdk.frameworks.AppKit reference
willcforte
marked this pull request as ready for review
October 3, 2026 00:18
Member
|
Congrats on your first PR!! 🙌 Thanks! will merge this asap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building
packages.default(ordevShells.default) for MacOS (Darwin) fails during evaluation:Cause
flake.nixreferences the legacydarwin.apple_sdk.frameworks.AppKitattribute in bothpackages.default.buildInputsanddevShells.default.buildInputs.nixpkgs removed
darwin.apple_sdk{ , _11_0, _12_3}in NixOS/nixpkgs#429387. As per nixpkgs migration notes:So any nixpkgs version after this (e.g.
nixos-unstable) will trigger this evaluation error.This deprecation only breaks compatibility for
nixpkgsversions before NixOS/nixpkgs#346043 merged on October 10th, 2024.Changes made
This PR removes
apple_sdk.frameworks.AppKitbuildInput frompackages.defaultanddevShells.default.Testing
Verified on
aarch64-darwin:Build completes cleanly on my machine.
Yay! This is my first OSS PR :)