BundleRoute: don't rebuild on every artifact GET (#97) - #103
Draft
nounder wants to merge 1 commit into
Draft
Conversation
Previously every GET to /_bundle/* called bundle.rebuild() when the bundle context exposed a rebuild function, forcing a full bundler rerun on every asset request in production. Gate the rebuild on Development being present in context so it only runs during dev; production relies on the bundle staying fresh via file watch + BundleContext.events instead of a per-request rebuild. Adds tests asserting no rebuild happens outside of Development and that it does happen when Development is provided. Co-authored-by: Ralph Gutkowski <nounder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97
Summary
BundleRoutewas callingbundle.rebuild()on everyGET /_bundle/*wheneverrebuildwas present, causing a full bundler rerun per asset — including in production.This gates rebuild on
Developmentbeing in context. In production, artifacts are served as-is and freshness comes from file watch +BundleContext.events.Changes
bundle.rebuild()onDevelopment.optioninBundleRouteTest plan
bun test test/bundler/BundleRoute.test.ts