Route.redirect: accept cookies and headers (#95) - #105
Draft
nounder wants to merge 2 commits into
Draft
Conversation
Extend Route.redirect to accept a cookies option (Cookies.Cookies) and a headers option, so redirects can carry a set-cookie header alongside the Location header. Cookies are serialized with Cookies.toSetCookieHeaders and merge with any set-cookie headers appended by wrapping route layers. Fixes #95
Use the RouteSet-returning layer shape expected by Route.use, and adjust the expected set-cookie order to match how Entity.merge appends the wrapping layer's cookie after the inner route's. Refs #95 Co-authored-by: Ralph Gutkowski <nounder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95
Summary
Route.redirectpreviously only setlocation(and optionalstatus). Use cases that needset-cookieon redirects had to drop down to rawEntity.make.Changes
Route.redirectoptions withcookies?: Cookies.Cookiesandheaders?: Entity.HeadersCookies.toSetCookieHeadersTest plan
bun test test/Route.test.tsx