Route.link: encode array searchParams as repeated keys (#92) - #106
Draft
nounder wants to merge 1 commit into
Draft
Route.link: encode array searchParams as repeated keys (#92)#106nounder wants to merge 1 commit into
nounder wants to merge 1 commit into
Conversation
schemaSearchParams already decodes repeated query keys into arrays (via Http.mapUrlSearchParams), but Route.link only ever stringified a single value when encoding, producing a comma-joined value instead of repeated key=value entries. Handle array values by appending each item as its own query string entry, and add regression tests. Co-authored-by: Ralph Gutkowski <nounder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92
Summary
Route.linkalready supported search params, including typedschemaSearchParams. Array values were incorrectly stringified instead of encoded as repeated query keys (matching how decode already handles them).Changes
key=valueentriesTest plan
bun test test/Route.test.tsx