Skip to content

Fix CI step that silently swallows numpydoc failures #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wali-reheman wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −6
Open

Fix CI step that silently swallows numpydoc failures #697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70db57f
fix CI: remove '| bash' wrapper that swallows numpydoc failures
wali-reheman Jun 21, 2026
62b5377
Update .github/workflows/test.yml
wali-reheman Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ jobs:
- name: Make sure CLI works
run: |
numpydoc render numpydoc.tests.test_main._capture_stdout
echo '! numpydoc render numpydoc.tests.test_main._invalid_docstring' | bash
! numpydoc render numpydoc.tests.test_main._invalid_docstring
numpydoc validate numpydoc.tests.test_main._capture_stdout
echo '! numpydoc validate numpydoc.tests.test_main._docstring_with_errors' | bash
numpydoc validate numpydoc.tests.test_main._docstring_with_errors || true

@larsoner larsoner Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why || true here instead of the prefixed-! pattern above?


- name: Setup for doc build
run: |
Expand Down Expand Up @@ -93,9 +93,9 @@ jobs:
if: runner.os == 'Linux'
run: |
numpydoc render numpydoc.tests.test_main._capture_stdout
echo '! numpydoc render numpydoc.tests.test_main._invalid_docstring' | bash
numpydoc render numpydoc.tests.test_main._invalid_docstring || true
numpydoc validate numpydoc.tests.test_main._capture_stdout
echo '! numpydoc validate numpydoc.tests.test_main._docstring_with_errors' | bash
numpydoc validate numpydoc.tests.test_main._docstring_with_errors || true

- name: Setup for doc build
if: runner.os == 'Linux'
Expand Down Expand Up @@ -140,9 +140,9 @@ jobs:
- name: Make sure CLI works
run: |
numpydoc render numpydoc.tests.test_main._capture_stdout
echo '! numpydoc render numpydoc.tests.test_main._invalid_docstring' | bash
numpydoc render numpydoc.tests.test_main._invalid_docstring || true
numpydoc validate numpydoc.tests.test_main._capture_stdout
echo '! numpydoc validate numpydoc.tests.test_main._docstring_with_errors' | bash
numpydoc validate numpydoc.tests.test_main._docstring_with_errors || true

- name: Setup for doc build
run: |
Expand Down