Repository navigation
Don't list git subcommands twice in completions - #1290
Merged
Merged
Conversation
Subcommands with their own extern were showing up twice when completing git <tab>, once from the extern and once from git help -a. Leave those out of the git command completion. Aliases and commands without an extern still complete.
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1197
When you source the git completions and type
git ad<tab>,addshows up twice. One comes from thegit addextern and the other from thecommandparameter ongit, which completes everything ingit help -a.Instead of dropping the
commandcompletion completely (like suggested in the issue), this filters out subcommands that already have their own extern. That way git aliases and commands without an extern still complete.Tested with nu 0.116.2 using
--ide-complete. Before the changegit adgivesaddandgit add, after it onlygit add. Aliases likecostill show up forgit c.