Repository navigation
jalon-git: fix the prompt on current nushell - #1299
Merged
Merged
Conversation
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jalon-git prompt doesn't load on current nushell, and once that's fixed a couple of other things break too.
do -pdoesn't exist anymore, so the module fails to parse. The two git calls now usecompleteand read stdout, which also means nothing goes wrong outside a git repo (do -istill errors there because git exits with 128)current-dir-styleuseddo --ignore-errors { path relative-to } | str join, which errors with "Pipeline empty" when the current dir isn't under home. Switched it totry/catchfast-git-stylefailed on a branch with no upstream, since the optionalstategroup is empty andsplit rowgot nothing. It now defaults to an empty stringTested
full-left-promptandleft-prompt [user dir fast-git duration]on 0.116.1 in a repo outside home, a repo under home, a non-repo dir, home itself, a branch 2 commits ahead of its upstream and a detached HEAD.