Skip to content

jalon-git: fix the prompt on current nushell - #1299

Merged
fdncred merged 1 commit into
nushell:mainfrom
qodelicious:fix-jalon-git-do-flag
Oct 22, 2026
Merged

fdncred merged 1 commit into
nushell:mainfrom
qodelicious:fix-jalon-git-do-flag

Conversation

@qodelicious

Copy link
Copy Markdown
Contributor

The jalon-git prompt doesn't load on current nushell, and once that's fixed a couple of other things break too.

  • do -p doesn't exist anymore, so the module fails to parse. The two git calls now use complete and read stdout, which also means nothing goes wrong outside a git repo (do -i still errors there because git exits with 128)
  • current-dir-style used do --ignore-errors { path relative-to } | str join, which errors with "Pipeline empty" when the current dir isn't under home. Switched it to try/catch
  • fast-git-style failed on a branch with no upstream, since the optional state group is empty and split row got nothing. It now defaults to an empty string

Tested full-left-prompt and left-prompt [user dir fast-git duration] on 0.116.1 in a repo outside home, a repo under home, a non-repo dir, home itself, a branch 2 commits ahead of its upstream and a detached HEAD.

@fdncred
fdncred merged commit d793938 into nushell:main Oct 22, 2026
1 check passed
@fdncred

fdncred commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants