Skip to content

feat(deps): migrate to ipx v4#2094

Open
danielroe wants to merge 1 commit into
mainfrom
feat/ipx-v4
Open

feat(deps): migrate to ipx v4#2094
danielroe wants to merge 1 commit into
mainfrom
feat/ipx-v4

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #2063

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

this migrates us to ipx v4 (it's alpha, so this is just testing for now)

@danielroe
danielroe requested a review from pi0 January 22, 2026 22:56
@pkg-pr-new

pkg-pr-new Bot commented Jan 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@2094

commit: 20a26a9

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jan 22, 2026

Copy link
Copy Markdown

Deploying nuxt-image with  Cloudflare Pages  Cloudflare Pages

Latest commit: 20a26a9
Status: ✅  Deploy successful!
Preview URL: https://b5f7eb41.nuxt-image.pages.dev
Branch Preview URL: https://feat-ipx-v4.nuxt-image.pages.dev

View logs

@codecov-commenter

codecov-commenter commented Jan 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.61%. Comparing base (41790ef) to head (20a26a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2094   +/-   ##
=======================================
  Coverage   32.61%   32.61%           
=======================================
  Files           7        7           
  Lines         371      371           
  Branches      131      131           
=======================================
  Hits          121      121           
  Misses        194      194           
  Partials       56       56           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maximepvrt maximepvrt mentioned this pull request Jul 21, 2026
1 task
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedipx@​3.1.1 ⏵ 4.0.0-alpha.2100 +210010089100

View full report

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The IPX dependency is upgraded from ^3.1.1 to ^4.0.0-alpha.2 in development and optional dependencies. The server route switches from the H3 IPX handler and useBase to createIPXFetchHandler, manually removes the configured base URL, forwards the adjusted request method and headers, and sends the returned web response.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: migrating to ipx v4.
Description check ✅ Passed The description is clearly related and matches the dependency/API migration work in the PR.
Linked Issues check ✅ Passed The changes update ipx to v4 and switch the route to the new fetch-based API, matching issue #2063.
Out of Scope Changes check ✅ Passed The PR only changes the ipx dependency and its route integration, with no obvious unrelated additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ipx-v4

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/runtime/server/routes/_ipx.ts (1)

30-54: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add regression coverage for the H3-to-Fetch translation.

Codecov reports no coverage for this new path. Add tests for the default and a custom baseURL, including query preservation and successful image response forwarding; this replaces useBase’s previously tested framework behavior.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/runtime/server/routes/_ipx.ts` around lines 30 - 54, Add regression tests
covering the H3 event handler’s Fetch translation through _handler: verify the
default and custom baseURL paths are stripped correctly, query parameters are
preserved, and a successful image response is forwarded. Replace the prior
useBase framework-behavior coverage with these route-specific tests.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/runtime/server/routes/_ipx.ts`:
- Around line 30-54: Add regression tests covering the H3 event handler’s Fetch
translation through _handler: verify the default and custom baseURL paths are
stripped correctly, query parameters are preserved, and a successful image
response is forwarded. Replace the prior useBase framework-behavior coverage
with these route-specific tests.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 914afa4a-163b-44af-aed0-6c5871076611

📥 Commits

Reviewing files that changed from the base of the PR and between 41790ef and 20a26a9.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • src/runtime/server/routes/_ipx.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to new ipx APIs

2 participants