[IMP] empty#5184
Open
arpi-odoo wants to merge 3 commits into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding, it needs to be retargeted before it can be merged. |
Steps to reproduce: - Open an employee without a contract start date. - Check the contract section. Cause: The "New Contract" button was displayed even when no contract start date was defined. Solution: Add an invisible condition on the button to hide it when contract_date_start is not set. Task: 6326571
Step to reproduce: Search on the virtual_remaining_leaves field using a comparison operator such as '>'. Cause: The search method called the comparison operator with only the field value, while operators such as operator.gt expect both the field value and the domain value. Solution: Pass the domain value to the comparison operator and add a test covering a search on virtual_remaining_leaves with an allocated leave type. Task: 6327165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.