19.0 tutorials- Server framework 101 ( PIKRI )#1355
Draft
Piyush11204 wants to merge 16 commits into
Draft
Conversation
|
|
Clean up coding style issues in the estate module to improve code consistency and comply with the expected linting conventions. Adjust formatting and code structure without changing the existing functional behavior.
Piyush11204
force-pushed
the
19-tutorial-pikri
branch
from
July 3, 2026 06:36
410170f to
4bea8f1
Compare
Resolve linting errors reported in the estate module and adjust the affected code to comply with the expected coding standards. These changes improve code quality without modifying the functional behavior of the module.
Piyush11204
force-pushed
the
19-tutorial-pikri
branch
from
July 3, 2026 08:56
51ea9f3 to
99f7eb7
Compare
Add access control rules for the estate property model to define the required permissions for creating, reading, updating, and deleting property records. This makes the model accessible through the application while following Odoo's model security mechanism.
Fix the remaining code quality and formatting issues identified in the estate module. Clean up the affected code to maintain consistency with the expected coding and linting conventions.
Correct spacing and formatting inconsistencies in the estate module to improve readability and comply with the expected coding style. This change only affects code formatting and does not alter existing functionality.
Add the initial estate property model with the core fields required to represent and manage real estate properties. Define the basic property attributes and model structure needed as the foundation for the estate application.
Piyush11204
force-pushed
the
19-tutorial-pikri
branch
from
July 3, 2026 12:06
58a5db4 to
f8a252c
Compare
Add the initial user interface for managing estate properties, including the required property views, window action, and menu entries. This makes property records accessible and manageable directly from the estate application.
Set the default number of bedrooms for estate properties and correct the default computation of the availability date. This ensures newly created property records are initialized with the expected default values.
Improve the estate property interface with a more detailed form layout and additional search options. Organize property information for better readability and provide search capabilities that make property records easier to find and manage.
Add a dedicated search filter for expensive properties to make it easier to identify records matching the configured price criteria. This extends the property search view with an additional filtering option for more efficient property management.
Add property type and property tag models to provide structured classification of estate properties. Integrate the new relational fields into the property model and enhance the property form so users can assign types and tags while managing property records.
Fix the linting issues reported by Runbot in the estate module and adjust the affected code to comply with the expected coding standards. This ensures the module passes the automated code quality checks without changing its functional behavior.
Piyush11204
force-pushed
the
19-tutorial-pikri
branch
2 times, most recently
from
July 9, 2026 12:13
8ce52d1 to
24e0f40
Compare
Add the estate property offer model to represent offers submitted for individual properties. Establish the relationship between properties and their offers and integrate offer management into the property form for convenient access to associated offer records.
Correct the readonly configuration of the property_id field in the estate property offer model. This ensures the property relationship behaves as intended when offers are created and managed through the property form.
bit-odoo
reviewed
Jul 20, 2026
bit-odoo
left a comment
bit-odoo
left a comment
There was a problem hiding this comment.
Hello @Piyush11204
Good Start!
First, can you please improve all your commit titles and add the message as well?
And you have left many unneccary empty lines.
Also, improve the PR title and description.
Thanks
| date_availability = fields.Date( | ||
| copy=False, default=lambda self: fields.Date.add(fields.Date.today(), months=3) | ||
| ) | ||
|
|
|
|
||
| expected_price = fields.Float(required=True) | ||
| selling_price = fields.Float(readonly=True, copy=False) | ||
|
|
| bedrooms = fields.Integer(default=2) | ||
| living_area = fields.Integer() | ||
| facades = fields.Integer() | ||
|
|
| garage = fields.Boolean() | ||
| garden = fields.Boolean() | ||
| garden_area = fields.Integer() | ||
|
|
| <field name="name">Property Tags</field> | ||
| <field name="res_model">estate.property.tag</field> | ||
| <field name="view_mode">list,form</field> | ||
|
|
Comment on lines
+53
to
+55
|
|
||
|
|
||
|
|
Piyush11204
changed the title
Piyush11204
force-pushed
the
19-tutorial-pikri
branch
3 times, most recently
from
July 21, 2026 08:58
912875e to
3897a20
Compare
Author
Hello Sir, Thank you for reviewing my PR. I have fixed all the changes you suggested
Thank you. |
Clean up unnecessary whitespace and improve formatting across the property and offer models, menus, and views. This refactoring improves code readability and consistency without changing any existing functionality or behavior. Related PR: odoo#1355 Signed-off-by: Piyush Yadav<pikri@odoo.com>
Piyush11204
force-pushed
the
19-tutorial-pikri
branch
from
July 21, 2026 12:31
3897a20 to
8d9d8f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains my work on the Real Estate module from the Server Framework 101 tutorial.
It includes the property, property type, tag, and offer models, along with their fields and relationships. It also adds the required views, menus, actions, access rights, and the business logic implemented throughout the tutorial.
This PR covers the changes made while progressing through the Server Framework 101 chapters.