19.0 tutorials prway#1358
Draft
prway-odoo wants to merge 11 commits into
Draft
Conversation
-Add the basic structure for the estate module as part of the Odoo Server Framework 101 training.
|
|
prway-odoo
force-pushed
the
19.0-tutorials-prway
branch
from
July 20, 2026 10:59
cc47e43 to
b24eefb
Compare
bit-odoo
reviewed
Jul 21, 2026
bit-odoo
left a comment
bit-odoo
left a comment
There was a problem hiding this comment.
Hello @prway-odoo
Good Start!
Can you please improve all your commit titles and add the commit message as well?
Also, improve the PR title and description.
And you have left many unneccary empty lines.
Thanks
Comment on lines
+1
to
+2
| from datetime import timedelta | ||
| from odoo import models, fields |
There was a problem hiding this comment.
Please followe the import coding guidelines.
| @@ -0,0 +1,3 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 | |||
| ,,,,,,, No newline at end of file | |||
There was a problem hiding this comment.
unneccary diff and should be one empty line at the end of the file.
Comment on lines
+69
to
+72
| <filter | ||
| name="available" | ||
| string="Available" | ||
| domain="['|',('state','=','new'),('state','=','offer_received')]"/> |
Comment on lines
+75
to
+78
| <filter | ||
| name="group_by_postcode" | ||
| string="Postcode" | ||
| context="{'group_by':'postcode'}"/> |
| readonly=True, | ||
| copy=False, | ||
| ) | ||
|
|
| ) | ||
|
|
||
| bedrooms = fields.Integer(default=2) | ||
|
|
| garage = fields.Boolean() | ||
| garden = fields.Boolean() | ||
| garden_area = fields.Integer() | ||
|
|
| <field name="expected_price"/> | ||
| <field name="selling_price"/> | ||
| </group> | ||
|
|
| <field name="state"/> | ||
| </group> | ||
| </group> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.