Skip to content

19.0 tutorials karad#1364

Open
karad-odoo wants to merge 17 commits into
odoo:19.0from
odoo-dev:19.0-tutorials-karad
Open

19.0 tutorials karad#1364
karad-odoo wants to merge 17 commits into
odoo:19.0from
odoo-dev:19.0-tutorials-karad

Conversation

@karad-odoo

@karad-odoo karad-odoo commented Jul 20, 2026

Copy link
Copy Markdown

[ADD] estate: property model, security rules, and UI views

Initial setup for the estate tutorial module.

  • Added estate.property model with fields and defaults
  • Set up security access rights (ir.model.access.csv)
  • Added List, Form, and Search views
  • Configured actions and menu items

karad-odoo added 16 commits July 2, 2026 18:04
- Create initial module directory with __manifest__.py and __init__.py files
  for the Odoo training tutorial.
- Add author and license attributes to __manifest__.py.
- Fix code formatting issues across the module.
- Remove empty or unused default fields from __manifest__.py.
- Create 'estate.property' model definition inside models/estate_property.py.
- Define core scalar fields for real estate advertisements.
- Clean up Python and XML files to adhere to Odoo PEP8 and XML linting standards.
- Add ir.model.access.csv under security directory.
- Register security file in __manifest__.py data list.
- Grant CRUD permissions on 'estate.property' to base.group_user.
- Define window action and 3-tier menu structure for estate module.
- Set 'selling_price' field as read-only and disable copy attribute on price fields.
- Set default business values for bedrooms and default availability lag.
- Add 'active' and 'state' tracking fields to estate.property.
- Add .idea/ folder to .gitignore.
- Remove cached PyCharm environment files from git tracking.
- Add list view for 'estate.property' containing key fields including title, postcode,
  living area, and pricing attributes.
- Rename list view fields 'title' to 'name' and 'available_from' to 'date_availability'
  to match Python model field definitions.
- Fix ParseErrors encountered during module loading.
- Add basic form view architecture for 'estate.property'.
- Organize view structure with title, property parameters group, and a description notebook.
- Add initial search view definition for 'estate.property'.
- Include searchable fields: title, postcode, expected_price, bedrooms, living_area, and facades.
- Add predefined filter for available properties (state 'new' or 'offer_received').
- Add 'Postcode' group-by rule to the search view layout.
- Configure 'selling_price' field as read-only.
- Prevent field duplication on copy for prices and availability dates.
- Add default values for bedrooms and date_availability.
- Add 'state' selection field and 'active' boolean for record lifecycle tracking.
- Increase module version in __manifest__.py to force Odoo database registry update.
- Reorder model fields to position 'state' before 'active' attribute.
- Fix form view name definition from 'estate.property.list' to 'estate.property.form'.
- Add missing 'state' field to both list and form views.
- Remove redundant string attributes on search fields to inherit model labels.
- Clean up syntax formatting, filter spacing, and group-by layout in search view..
@robodoo

robodoo commented Jul 20, 2026

Copy link
Copy Markdown

Pull request status dashboard

@karad-odoo
karad-odoo requested a review from bit-odoo July 20, 2026 09:07

@bit-odoo bit-odoo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @karad-odoo
Good Start!

Can you please improve all your commit titles and message as well?
And you have left many unneccary empty lines.

Also, improve the PR title and description.

Thanks

Comment thread estate/security/ir.model.access.csv Outdated
@@ -0,0 +1,2 @@
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be one empty line at the end of the file.

Comment thread estate/views/estate_property_views.xml Outdated
Comment on lines +8 to +10
<menuitem id="estate_menu_root" name="Real Estate"/>
<menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/>
<menuitem id="estate_property_menu_action" name="Properties" parent="estate_first_level_menu"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create a separate file for the menu.

Comment thread estate/views/estate_property_views.xml Outdated
<field name="name">estate.property.list</field>
<field name="model">estate.property</field>
<field name="arch" type="xml">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneccary empty line.

Comment thread estate/views/estate_property_views.xml Outdated
<field name="date_availability" string="Available From"/>
<field name="state" string="State"/>
</list>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneccary empty line.

Comment thread estate/views/estate_property_views.xml Outdated
<field name="name">estate.property.form</field>
<field name="model">estate.property</field>
<field name="arch" type="xml">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneccary empty line.

Comment thread estate/views/estate_property_views.xml Outdated
</group>
</page>
</notebook>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneccary empty line.

Comment thread estate/views/estate_property_views.xml Outdated

</sheet>
</form>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneccary empty line.

Comment thread estate/views/estate_property_views.xml Outdated
<field name="selling_price"/>
</group>
</group>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneccary empty line.

Comment thread estate/views/estate_property_views.xml Outdated
</field>
</record>

</odoo> No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be one empty line at the end of the file.

Comment thread .gitignore

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneccary diff.

- Move menu items from estate_property_views.xml to views/estate_menus.xml
  to maintain view separation standards.
- Update __manifest__.py data order to load menus after views.
- Clean up whitespace and ensure files end with a trailing newline.
@karad-odoo
karad-odoo force-pushed the 19.0-tutorials-karad branch from 8208a5f to f2a88fc Compare July 21, 2026 09:13
@karad-odoo
karad-odoo marked this pull request as ready for review July 21, 2026 09:26
@karad-odoo
karad-odoo requested a review from bit-odoo July 21, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants