Skip to content

Improve visibility of button hover and focus states - #1362

Merged
flooguu merged 2 commits into
mainfrom
113_improve_visibility_of_focussed_buttons
Nov 18, 2026
Merged

flooguu merged 2 commits into
mainfrom
113_improve_visibility_of_focussed_buttons

Conversation

@flooguu

@flooguu flooguu commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@flooguu
flooguu requested a review from noeddl October 13, 2026 12:55
@noeddl

noeddl commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

I like the approach of having a light and a dark ring that work well against different background colors and can be switched in dark mode. Tabbing over some pages, I found that the new styling is applied to some, but not all kinds of interactive elements.

The cases I found:

  • Select buttons do not have two rings but just one thick dark outline. (The two rings do work for other elements such as input fields.)
Bildschirmfoto vom 2026-10-14 10-22-53
  • The ring-color switch in dark mode does not work for some elements such as input fields and radio buttons (and again select buttons): The inner ring is still light and the outer ring is still dark.
Bildschirmfoto vom 2026-10-14 10-18-48 Bildschirmfoto vom 2026-10-14 10-18-23 Bildschirmfoto vom 2026-10-14 10-22-27
  • Not sure what do about simple links. Currently they have a red/white outline when focused which does not match the other elements, but that's maybe okay for now.
Bildschirmfoto vom 2026-10-14 10-49-08 Bildschirmfoto vom 2026-10-14 10-47-59

@flooguu
flooguu merged commit 32a72cc into main Nov 18, 2026
4 checks passed
@flooguu
flooguu deleted the 113_improve_visibility_of_focussed_buttons branch November 18, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants