Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Pull request overview
This PR makes controlled sessions “fail closed” when the cleanup watchdog process exits unexpectedly, distinguishing this from Docker runtime-observation loss and surfacing a dedicated lifecycle cause/observation plus a safe diagnostic.
Changes:
- Extend the watchdog runtime interface to expose
Done(),ExitError(), andClose()so the supervisor can detect and react to premature watchdog exit. - Add a new lifecycle observation/cause (
cleanup-containment-lost) and update the Docker supervisor to observe watchdog exit both during startup and while active, emitting a bounded diagnostic event when possible. - Add/extend unit + integration tests, update design docs, and include a Changie fragment for the behavior change.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/dockerdeploy/controlled_session_watchdog.go | Extends watchdog runtime interface for exit observability and explicit closure. |
| internal/dockerdeploy/controlled_session_watchdog_linux.go | Implements watchdog exit tracking (Done/ExitError) and idempotent Close; refactors readiness/teardown coordination. |
| internal/dockerdeploy/controlled_session_watchdog_integration_linux_test.go | Updates integration test to use the new watchdog exit channel/error surface. |
| internal/dockerdeploy/controlled_session_supervisor.go | Observes watchdog exit (startup + active), latches containment-loss observation, emits diagnostic, and adjusts teardown behavior accordingly. |
| internal/dockerdeploy/controlled_session_supervisor_test.go | Adds regression tests for failing closed after watchdog exit (startup + active) and extends fakes to support new watchdog/channel behaviors. |
| internal/controlledsession/model.go | Adds new termination cause constant and validation support. |
| internal/controlledsession/lifecycle.go | Adds new observation kind that latches the cleanup-containment-lost cause. |
| internal/controlledsession/lifecycle_test.go | Adds coverage ensuring the new cause participates correctly in lifecycle behavior and racing. |
| docs/CONTROLLED_SESSION_DESIGN.md | Documents the new containment-loss semantics and diagnostic behavior. |
| .changes/unreleased/+controlled-session-cleanup-containment-loss.yaml | Release note fragment for the user-visible behavior change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6c0fb6361
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 492fcbe498
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 492fcbe498
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Stack created with Sapling. Best reviewed with ReviewStack.