Plan controlled-session networking by omry · Pull Request #38 · omry/reploy

omry · 2026-08-10T16:21:45Z

Stack created with Sapling. Best reviewed with ReviewStack.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

chatgpt-codex-connector · 2026-08-10T16:27:00Z

💡 Codex Review

reploy/internal/blueprint/model.go

Lines 272 to 274 in 08030fb

    
           type SystemInstall struct { 
        
           	Account SystemAccount 
        
           }

Migrate old resolved documents before renaming RunAs

When upgrading any deployment written by the previous version, its blueprint-resolved-v1 payload still contains Environment.Install.System.RunAs. DecodeResolvedDocumentV1 uses DisallowUnknownFields, so replacing that field with Account makes the persisted state fail immediately; additionally, the new Environment.Runtime field would make older payloads fail the exact canonical re-encoding check. Runtime commands, rebuilds, and uninstall therefore cannot load existing state. Add a versioned compatibility decoder/migration before changing this persisted shape.

reploy/internal/dockerdeploy/controlled_session_plan.go

Lines 733 to 735 in 08030fb

    
           Image: dockerPlan.Image, Container: dockerPlan.ContainerName + "-" + string(role) + "-" + liveRunID, 
        
           RuntimeIdentity: identity, Network: controlledSessionNetworkModeV1, SessionNetwork: sessionNetwork, 
        
           ReadOnlyRoot: dockerPlan.Sandbox.ReadOnlyRoot, TemporaryHome: dockerPlan.Sandbox.TemporaryHome,

Realize the session network before reporting endpoints

When EndpointIDs is nonempty, the plan records a lease-private SessionNetwork and the opened event advertises the workload alias, but both container create commands still unconditionally use --network none. The supervisor never creates or connects the planned network—in fact its cleanup-manifest validation rejects any networks—so the controller cannot resolve or reach any advertised endpoint. Create and attach the lease network before startup (and track it for cleanup), or reject endpoint grants until that runtime support exists.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-10T16:29:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08030fb48b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-10T16:43:43Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec342ca2c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-10T16:53:55Z

@codex review

chatgpt-codex-connector · 2026-08-10T16:57:13Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: a0a1b94e2c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-10T16:59:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0a1b94e2c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry · 2026-08-10T17:13:28Z

@codex review

chatgpt-codex-connector · 2026-08-10T17:16:28Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 5eef638511

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI lite review requested due to automatic review settings August 10, 2026 16:21

Copilot AI reviewed Aug 10, 2026

omry changed the base branch from main to pr37 August 10, 2026 16:23

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread internal/controlledsession/protocol.go Outdated

omry force-pushed the pr38 branch from 08030fb to ec342ca Compare August 10, 2026 16:42

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread internal/dockerdeploy/controlled_session_plan.go Outdated

omry force-pushed the pr38 branch from ec342ca to a0a1b94 Compare August 10, 2026 16:52

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread internal/controlledsession/protocol.go Outdated

Plan controlled-session networking

5eef638

omry force-pushed the pr38 branch from a0a1b94 to 5eef638 Compare August 10, 2026 17:06

omry added the approved PR reviewed and approved label Aug 10, 2026

This was referenced Aug 10, 2026

Add controlled-session network adapter #39

Open

Persist controlled-session network ownership #40

Open

Integrate controlled-session networking #41

Open

Navigation Menu

Plan controlled-session networking - #38

Plan controlled-session networking#38
omry wants to merge 1 commit into
pr37from
pr38

omry commented Aug 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

Uh oh!

omry commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

omry commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

omry commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

Uh oh!

omry commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

omry commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

omry commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

💡 Codex Review

Uh oh!

omry commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

omry commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

omry commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

Uh oh!

omry commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

omry commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

omry commented Aug 10, 2026 •

edited

Loading