Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d70a031b50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR updates the controlled-session design documentation to “freeze” the OmegaFlow-facing integration contract for controller-controlled workloads, with an explicit broker + terminal-attachment split and a versioned JSON-lines public stream boundary.
Changes:
- Refines the output-dir/output-file section to align with the planned
reploy controlled-session runhost command surface. - Replaces the prior “asciinema ↔ session client” topology with a broker + terminal attachment contract (including lifecycle ordering and security expectations).
- Adds a detailed Slice 5 breakdown describing how the integration boundary will be implemented and proven in later reviewable steps.
Suppressed comments (1)
docs/CONTROLLED_SESSION_DESIGN.md:1155
- This paragraph mixes the terms “broker” and the
clientsubcommand when describing stdin/stdout/stderr, which makes it unclear whetherreploy controlled-session clientis the broker process. Using one term consistently here would reduce ambiguity in the integration contract.
The broker's stdin and stdout carry only the versioned structured OmegaFlow
control stream; its stderr carries human diagnostics. The attachment's stdin
and stdout carry only terminal bytes. `REPLOY_SESSION_SOCKET` is consumed
implicitly by `client` and has no command-line override. The broker creates the
terminal socket itself and reports its path to OmegaFlow before OmegaFlow
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Define the Reploy-owned public boundary for OmegaFlow-controlled workloads, including the embedded controller broker, terminal-only attachment, unmodified asciinema integration, and strict versioned JSON stream. Specify attachment security and lifecycle ordering, host CLI arguments and structured results, timeout and cancellation behavior, controller-output finalization, Linux-only controller support, and compatibility expectations. Split implementation into independently reviewed broker, attachment, packaging, host invocation, and conformance slices.
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Define the Reploy-owned public boundary for OmegaFlow-controlled workloads, including the embedded controller broker, terminal-only attachment, unmodified asciinema integration, and strict versioned JSON stream.
Specify attachment security and lifecycle ordering, host CLI arguments and structured results, timeout and cancellation behavior, controller-output finalization, Linux-only controller support, and compatibility expectations. Split implementation into independently reviewed broker, attachment, packaging, host invocation, and conformance slices.
Stack created with Sapling. Best reviewed with ReviewStack.