Skip to content

Use GeoJsonSerializer when geojson is requested via the format query param #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −1
Open

Use GeoJsonSerializer when geojson is requested via the format query param #3124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2947868
Use GeoJsonSerializer when geojson is requested via the format query …
SAY-5 Jun 9, 2026
f1f6c62
Merge branch 'main' into fix-dataview-geojson-query-param
SAY-5 Jun 16, 2026
c7b2861
Merge branch 'main' into fix-dataview-geojson-query-param
SAY-5 Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions onadata/apps/api/tests/viewsets/test_dataview_viewset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,6 +1506,18 @@ def test_geopoint_submission_dataview(self):
self.assertEqual(response.status_code, 404)
self.assertEqual({"detail": "Invalid page."}, response.data)

# geojson requested via the format query param (no format kwarg) should
# also use the GeoJsonSerializer instead of crashing with a TypeError
request = self.factory.get(
"/?format=geojson&geofield=_geolocation&page=1&page_size=1&fields=name",
**self.extra,
)
response = view(request, pk=self.data_view.pk)
headers = dict(response.items())
self.assertEqual(headers["Content-Type"], "application/geo+json")
self.assertEqual(response.status_code, 200)
self.assertEqual("FeatureCollection", response.data["type"])

# pylint: disable=invalid-name
def test_dataview_project_cache_cleared(self):
self._create_dataview()
Expand Down
2 changes: 1 addition & 1 deletion onadata/apps/api/viewsets/dataview_viewset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def get_serializer_class(self):
"""
Get a serializer class based on request format
"""
export_type = self.kwargs.get("format")
export_type = self.kwargs.get("format", self.request.GET.get("format"))
if self.action == "data" and export_type == "geojson":
serializer_class = GeoJsonSerializer
elif self.action == "data":
Expand Down