[Testing] Add lifecycle regression tests for grpcserver and optimistic sync pipeline - #8636
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
51233a4 to
12aa0a1
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Adds regression coverage for the two component-lifecycle fixes from #8633. Each new test was verified to fail with the corresponding fix reverted, and to pass with it.
Changes
module/grpcserver: first tests for the package. Verify a normal start/stop lifecycle throws nothing, that an immediate shutdown racing startup does not throwErrServerStopped(50 iterations amplify the race between the shutdown worker's GracefulStop and the serve worker reaching Serve), and that a genuine listen failure is still thrown as irrecoverable.StateWaitingPersistand never persisted; the test drives it toStateComplete.Related: #8633
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.