Repository navigation
fix: source template dependency guidance from nuxt-skills - #47
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes across the sync command, generated guidance, documentation, and publication tests.
- Authoritative source sync: Adds
pnpm sync:template-guidancewith local-source and remote-revision options, read-only checking, and source-digest provenance. - Template guidance: Publishes the upstream dependency-tracking reference in the module-authoring pack while preserving existing package, playground, and hosted loading paths.
- Publication coverage: Checks source-digest consistency and identical content across loaders, hosted output, and real module-author generation; keeps the hosted test in the docs type context.
- Verification: All 25 targeted tests, the remote sync check, and root/docs typechecks passed. Root lint passed for the changed script and root tests; its configuration ignores the docs test. Nuxt dependency behavior was also checked against current upstream documentation and implementation. The full suite and production docs build were not rerun.
gpt-6.1-sol ｜ 𝕏
|
Current-head evidence for ViteHub Babysitter: all seven checks now pass on a55c0e8, including Pullfrog. Pullfrog completed review with no findings: #47 (review). The separate Codex review still reports running. Source PR onmax/nuxt-skills#90 is merged by ViteHub bot; remote-main sync and --check matched with no generated diff. Maxi has authorized the bot to handle any in-scope findings and squash-merge when its review gates are satisfied. |
Latest result Pull request merged. Final answersSession Pull request merged. No actionable defects found. All six supplied checks passed; Pullfrog reported no findings. Remote sync checks against main and the merged source commit passed, as did local-source sync, idempotence, failure-without-write checks, targeted ESLint, and git diff --check. Checkout remains clean; no repair commit needed. Ready on inspected evidence, awaiting the already-running Codex review. |
The module-authoring pack omitted template dependency guidance and was maintained separately from nuxt-skills. Generate its template section from the authoritative nuxt-modules reference instead of maintaining another explanation.
Add
pnpm sync:template-guidancewith local source and remote ref options plus a read-only--checkmode. The generated section records the source digest. Existing package, playground, and hosted-skill loaders publish the same pack without fetching content at build time.The source guide merged in onmax/nuxt-skills#90 via ViteHub bot, commit
318734434db5e1342d48a3a4d1d72a00aeb6250a. Re-synced against remote nuxt-skills main and verified--check; generated output is unchanged and the checkout is clean. Ready for ViteHub Babysitter to repair in scope and squash-merge after checks/review, as authorized by Maxi.Validation: all six current-head checks passed. Targeted checks covered publication/router behavior, hosted skill content, and real module-author Nuxt prepare output. Root and docs typechecks passed separately; the hosted publication test stays in the docs project. Targeted lint and diff checks passed. Sync verification covered exact source content, idempotence, stale-source detection, invalid input rejection, and no writes on failure. No production deployment is requested.