Repository navigation
docs(nuxt-modules): clarify regeneration and lifecycle contracts - #91
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed all eight changed files and checked the substantive Nuxt contracts against the cited upstream implementation.
- Template regeneration: Clarifies restart-triggering watch entries, dependency-based invalidation, filtered
updateTemplates, watcher cleanup, and the distinction between template work and browser-visible HMR. - Lifecycle contracts: Corrects
onUpgradeargument order, documents project-local lifecycle state and non-fatal lifecycle errors, and explains that moving awaited work toreadystill delays initialization. - Skill packaging: Updates reference routing and README wording and aligns all four plugin manifests at
1.3.7. - Validation: Relative skill links pass. This documentation-only review used upstream source verification rather than runtime suites or performance benchmarks.
gpt-6.1-sol (free via Pullfrog for OSS) | 𝕏
Latest result Pull request merged. Final answersSession Pull request merged. Session Waiting for GitHub merge request 0b20e4c0-71a3-4f5c-9c92-9a122bd645d8. Ready; inspected all eight changed files and supplied reviews with no actionable findings. `node scripts/check-skill-links.mjs`, manifest-version assertions, and `git diff --check 3187344...HEAD` passed. Hosted ci, validate-skills, and pullfrog passed. Local lint/typecheck were unavailable because host installation rejects minimumReleaseAgeExcludePrune, which is unchanged from base. No repair commit was needed. |

Module authors following the template guide can add a restart pattern when they only intend to refresh a template. The testing guide also implies that moving an awaited fetch to
readyremoves startup delay and reversesonUpgrade's first two arguments.Clarify restart behavior, show filtered
updateTemplates, and separate template CPU work from browser-visible HMR claims. Correct the lifecycle signature, explain project-local.nuxtrcstate, and make the awaited-hook timing explicit. Update routing/README text and all four plugin manifests to 1.3.7.Follow-up to #90. Behavior was checked against Nuxt
fa1f7656e2c7c9743e8686d5f95dfc1779188123and the Nuxt 4.6.2 source cited in the research.Validation: targeted Markdown/manifest lint, skill validation, all relative skill links, matching manifest versions, and
git diff --checkpassed. Skills were synced through the repository script. This is documentation only; no runtime suites or new benchmarks ran.