Skip to content

docs(nuxt-modules): clarify regeneration and lifecycle contracts - #91

Merged
vite-hub[bot] merged 1 commit into
mainfrom
docs/module-regeneration-lifecycle
Oct 28, 2026
Merged

vite-hub[bot] merged 1 commit into
mainfrom
docs/module-regeneration-lifecycle

Conversation

@onmax

@onmax onmax commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Module authors following the template guide can add a restart pattern when they only intend to refresh a template. The testing guide also implies that moving an awaited fetch to ready removes startup delay and reverses onUpgrade's first two arguments.

Clarify restart behavior, show filtered updateTemplates, and separate template CPU work from browser-visible HMR claims. Correct the lifecycle signature, explain project-local .nuxtrc state, and make the awaited-hook timing explicit. Update routing/README text and all four plugin manifests to 1.3.7.

Follow-up to #90. Behavior was checked against Nuxt fa1f7656e2c7c9743e8686d5f95dfc1779188123 and the Nuxt 4.6.2 source cited in the research.

Validation: targeted Markdown/manifest lint, skill validation, all relative skill links, matching manifest versions, and git diff --check passed. Skills were synced through the repository script. This is documentation only; no runtime suites or new benchmarks ran.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T10:40:55.236610Z 5677a5b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes Reviewed all eight changed files and checked the substantive Nuxt contracts against the cited upstream implementation.

  • Template regeneration: Clarifies restart-triggering watch entries, dependency-based invalidation, filtered updateTemplates, watcher cleanup, and the distinction between template work and browser-visible HMR.
  • Lifecycle contracts: Corrects onUpgrade argument order, documents project-local lifecycle state and non-fatal lifecycle errors, and explains that moving awaited work to ready still delays initialization.
  • Skill packaging: Updates reference routing and README wording and aligns all four plugin manifests at 1.3.7.
  • Validation: Relative skill links pass. This documentation-only review used upstream source verification rather than runtime suites or performance benchmarks.

Pullfrog  | View workflow run | Using gpt-6.1-sol (free via Pullfrog for OSS) | 𝕏

@vite-hub

vite-hub Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Session Status Started Duration
Pending Completed Not started —
View session Waiting 2026-10-28T10:49:46.555Z 2m 23s

Latest result

Pull request merged.

Final answers

Session

Pull request merged.

Session

Waiting for GitHub merge request 0b20e4c0-71a3-4f5c-9c92-9a122bd645d8.

View session

Ready; inspected all eight changed files and supplied reviews with no actionable findings. `node scripts/check-skill-links.mjs`, manifest-version assertions, and `git diff --check 3187344...HEAD` passed. Hosted ci, validate-skills, and pullfrog passed. Local lint/typecheck were unavailable because host installation rejects minimumReleaseAgeExcludePrune, which is unchanged from base. No repair commit was needed.

@vite-hub
vite-hub Bot merged commit 525c01d into main Oct 28, 2026
3 checks passed
@onmax
onmax deleted the docs/module-regeneration-lifecycle branch November 1, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant