Fix: login auth type mail options#9
Open
galviset wants to merge 2 commits into
Open
Conversation
alexskr
reviewed
Nov 29, 2023
Contributor
There was a problem hiding this comment.
Thanks for the PR, I assume it works in your environment.
This PR is based on lirmm's fork of ontologies_linked_data which includes refactored notification so unit tests would not pass until ncbo#148 gets merged
Our options are:
- Merge ncbo#148
- disable unit test until PR is merged
- change 'LinkedData::Utils::Notifier' to 'LinkedData::Utils::Notifications'
I lean towards the second option. @mdorf, what is your preference?
Contributor
Contributor
|
@syphax-bouazzouni thanks for updating refactored notifications PR in the NCBO fork. We plan on merging it in the near future so this PR would be redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #5, mails not being sent if there is SMTP authentification in the backend configuration.