Skip to content

Fix: login auth type mail options#9

Open
galviset wants to merge 2 commits into
ontoportal:masterfrom
galviset:pr/fix/login-auth-type-mail-options
Open

Fix: login auth type mail options#9
galviset wants to merge 2 commits into
ontoportal:masterfrom
galviset:pr/fix/login-auth-type-mail-options

Conversation

@galviset

Copy link
Copy Markdown

Fixed #5, mails not being sent if there is SMTP authentification in the backend configuration.

@alexskr alexskr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I assume it works in your environment.

This PR is based on lirmm's fork of ontologies_linked_data which includes refactored notification so unit tests would not pass until ncbo#148 gets merged

Our options are:

  1. Merge ncbo#148
  2. disable unit test until PR is merged
  3. change 'LinkedData::Utils::Notifier' to 'LinkedData::Utils::Notifications'

I lean towards the second option. @mdorf, what is your preference?

@syphax-bouazzouni

Copy link
Copy Markdown
Contributor

hi @galviset, I think the easiest solution here, would to be remove the test in this PR.
in the case of NCBO (@mdorf , @alexskr ), I updated directly ncbo#148 to include this fix.

@alexskr

alexskr commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

@syphax-bouazzouni thanks for updating refactored notifications PR in the NCBO fork. We plan on merging it in the near future so this PR would be redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API email notifications SMTPAuthenticationError

3 participants