NO-ISSUE: Enable story tests - #388
Open
fantonangeli wants to merge 1 commit into
Open
Conversation
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
✅ Deploy Preview for openworkflow-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change cleanly re-enables previously excluded tests without altering runtime code paths or introducing configuration inconsistencies.
Pull request overview
Re-enables the diagram editor’s “story tests” by allowing *.story.test.{ts,tsx} files to run as part of the Vitest unit test project in @openworkflowspec/diagram-editor.
Changes:
- Removes the Vitest
excluderule that previously skippedtests/**/*.story.test.{ts,tsx}from theunitproject.
File summaries
| File | Description |
|---|---|
| packages/open-workflow-diagram-editor/vitest.config.ts | Stops excluding story test files so they execute again under the unit test suite. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to re-enable story tests