Skip to content

869 bug choices parameter for textfields on spell model have no effect#930

Merged
augustjohnson merged 5 commits into
stagingfrom
869-bug-choices-parameter-for-textfields-on-spell-model-have-no-effect
Jun 3, 2026
Merged

869 bug choices parameter for textfields on spell model have no effect#930
augustjohnson merged 5 commits into
stagingfrom
869-bug-choices-parameter-for-textfields-on-spell-model-have-no-effect

Conversation

@augustjohnson
Copy link
Copy Markdown
Collaborator

Here's roughly what I did:

  • Allowed spells to be nullable, due to empty data in spells-that-dont-suck.
  • Added a validation method into import that that checks choice constraints on models, it should fail now on bad choices.
  • Fixed a ton of spells with invalid casting_times, across srd-2024 and spells-that-dont-suck. I anticipate there remain some problems there, but the basics are within choices OR are null at this point, that's pretty good.
  • Added some tests for the fields that were untested.

@augustjohnson augustjohnson force-pushed the 869-bug-choices-parameter-for-textfields-on-spell-model-have-no-effect branch 2 times, most recently from 67decf2 to faa478f Compare June 3, 2026 00:56
augustjohnson and others added 3 commits June 2, 2026 20:00
Staging has migrations 0075-0079 that didn't exist when this branch was
cut. Renumber to avoid leaf node conflict.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
'1 hour' and '10 minutes' must be '1hour' and '10minutes' to match the
model's SPELL_CASTING_TIME_CHOICES enum.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@augustjohnson augustjohnson merged commit 74f5b43 into staging Jun 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] choices parameter for TextFields on Spell model have no effect

2 participants