[BUGFIX] Creature model now inherits from HasDescription#949
Merged
Conversation
augustjohnson
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the
Creaturemodel by adding theHasDescriptionabstract model to its inheritance chain. The reason for this is two-fold:"desc"field toCreature, which is required to close [DATA] Add missing Monster descriptions to SRD 5.1 Miscellaneous Creatures #934"crossreferences"field toCreature, which will be essential for creating cross-links on the frontend from a Creature to another type of resource (ie. linking to spells listed under monster spellcasting features)Several test cases needed to be updated to accurately reflect that the
Creatureendpoint now returns acrossreferencesfield