Fix webhook verification without Buffer#1950
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
HAYDEN-OAI
added
the
upstream
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bufferdecoding in webhook signature verification with the existing base64 and UTF-8 helpers.globalThis.Bufferwhile WebCrypto is available.Why
Runtimes with WebCrypto but no Node
Buffercould pass the crypto capability check and then crash while decoding the webhook secret or signature.Validation
./node_modules/.bin/jest tests/api-resources/webhooks.test.ts --runInBand./node_modules/.bin/prettier --check src/resources/webhooks/webhooks.ts tests/api-resources/webhooks.test.ts./node_modules/.bin/eslint src/resources/webhooks/webhooks.ts tests/api-resources/webhooks.test.ts./scripts/build./node_modules/typescript/bin/tsc