Reject emitted promises on error#1954
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
HAYDEN-OAI
added
the
upstream
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventEmitter.emitted(event)reject whenerroris emitted before the requested event.emitted('error')resolving with the error value.coreandlibEventEmitter implementations.Why
The docstring promised that
emitted()rejects onerror, but the implementation only listened for the requested event. Code awaiting a message-like event could hang forever if an error arrived first.Validation
./node_modules/.bin/jest tests/EventEmitter.test.ts --runInBand./node_modules/.bin/prettier --check src/lib/EventEmitter.ts src/core/EventEmitter.ts tests/EventEmitter.test.ts./node_modules/.bin/eslint src/lib/EventEmitter.ts src/core/EventEmitter.ts tests/EventEmitter.test.ts./node_modules/typescript/bin/tsc./scripts/build