Skip to content

Added taiwan strait (fixed) version#3877

Open
crunchybbb2-hash wants to merge 10 commits intoopenfrontio:mainfrom
crunchybbb2-hash:taiwanstraitlarge
Open

Added taiwan strait (fixed) version#3877
crunchybbb2-hash wants to merge 10 commits intoopenfrontio:mainfrom
crunchybbb2-hash:taiwanstraitlarge

Conversation

@crunchybbb2-hash
Copy link
Copy Markdown

@crunchybbb2-hash crunchybbb2-hash commented May 7, 2026

Description:

More balanced and larger version of the previous taiwan strait map
original #3853

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME
crunchybbbbb

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Walkthrough

The PR introduces a new regional map called "TaiwanStrait" by adding map data files, registering it in the game type system, including it in the map playlist frequency table, and providing English localization.

Changes

TaiwanStrait Map Addition

Layer / File(s) Summary
Map Data Assets
map-generator/assets/maps/taiwanstrait/info.json, resources/maps/taiwanstrait/manifest.json
New map metadata files define dimensions (map, map16x, map4x), mapInfoState with crop settings and color mappings, and nations array with coordinates, names, flags, and one special "Tea Plantations" entry with strength.
Game Type Registration
src/core/game/Game.ts
GameMapType enum gains new entry TaiwanStrait = "Taiwan Strait" and is added to mapCategories.regional list.
Map Registry & Playlist
map-generator/main.go, src/server/MapPlaylist.ts
Map registry updated to include new taiwanstrait test map; playlist frequency table assigns selection weight of 4 to TaiwanStrait.
Localization
resources/lang/en.json
English translation added: "taiwanstrait": "Taiwan Strait" under map section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🗺️ A strait of two finds its home,
In tiles and nations it shall roam,
Four times its chance to grace the play,
Taiwan Strait brings worlds' display! 🌏

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Added taiwan strait (fixed) version' directly describes the main change: adding a new Taiwan Strait map with improvements over a previous version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description directly references the changeset by describing it as a larger, more balanced version of a previous Taiwan Strait map, which aligns with the files being added for the Taiwan Strait map functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants