Repository navigation
Conversation
Ekhorn
force-pushed
the
feature/add-radio-card-component
branch
from
October 21, 2026 10:09
edaabbc to
85143ef
Compare
Contributor
Author
Ekhorn
marked this pull request as ready for review
October 21, 2026 18:54
MartinaeyNL
reviewed
Oct 22, 2026
Comment on lines
19
to
33
| @import "@vaadin/vaadin-lumo-styles/components/radio-group.css"; | ||
|
|
||
| or-vaadin-radio-group:has(> or-vaadin-radio-card)::part(group-field) { | ||
| gap: var(--or-radio-card-spacing, var(--lumo-space-xs)); | ||
| } | ||
|
|
||
| :root::before, | ||
| :host::before { | ||
| --_lumo-vaadin-radio-group-inject: 1; | ||
| --_lumo-vaadin-radio-group-inject-modules: | ||
| lumo_mixins_group-field, lumo_mixins_field-label, lumo_mixins_field-required, lumo_mixins_field-error-message, | ||
| lumo_mixins_field-helper, lumo_components_radio-group, lumo_mixins_field-internal; | ||
| --_lumo-or-vaadin-radio-card-inject: 1; | ||
| --_lumo-or-vaadin-radio-card-inject-modules: lumo_mixins_checkable-field, lumo_components_radio-button; | ||
| } |
Member
There was a problem hiding this comment.
Can we find an alternative for these changes? Would be pity if we have to reference or-vaadin-radio-card in here.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
This PR adds a radio-button like a card component intended to be used with
or-vaadin-radio-group(as mobile friendly alternative).Changelog
or-vaadin-radio-card, a more mobile-friendly alternative tovaadin-radio-buttonfor use inor-vaadin-radio-group. It shows the option as a card with aniconslot, reuses the Lumo radio styles and is styled through--or-radio-card-*properties.ui/AGENTS.md: how Vaadin applies styles with and without@openremote/theme, the public API, and when to use properties, parts, Lumo modules, variants or a new componentAGENTS.mdChecklist