Skip to content

Refactor centralize - #52

Merged
sepandhaghighi merged 9 commits into
devfrom
refactor-centralize
Aug 16, 2026
Merged

Refactor centralize#52
sepandhaghighi merged 9 commits into
devfrom
refactor-centralize

Conversation

@alirezazolanvari

Copy link
Copy Markdown
Member

What does this implement/fix? Explain your changes.

  • _model_function converted to a staticmethod and now receives model parameters via asdict

@codacy-production

codacy-production Bot commented Jul 28, 2026

Copy link
Copy Markdown

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov-commenter

codecov-commenter commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.69%. Comparing base (6cb9dd5) to head (d6afce8).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #52      +/-   ##
==========================================
- Coverage   98.73%   98.69%   -0.03%     
==========================================
  Files           9        9              
  Lines         235      229       -6     
  Branches       26       26              
==========================================
- Hits          232      226       -6     
  Misses          2        2              
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alirezazolanvari
alirezazolanvari marked this pull request as ready for review July 28, 2026 17:18
Comment thread CHANGELOG.md Outdated
Comment thread drux/base_model.py Outdated
Comment thread drux/base_model.py Outdated
Comment thread drux/hopfenberg.py Outdated
Comment thread drux/base_model.py Outdated
Comment thread drux/base_model.py Outdated
Comment thread CHANGELOG.md
@sepandhaghighi

Copy link
Copy Markdown
Member

@alirezazolanvari

Thanks for your efforts. I had intended to approve and merge this pull request, but upon further review, I noticed that the target branch is set to main instead of dev. Please check it again and then ping me.

@alirezazolanvari
alirezazolanvari changed the base branch from main to dev August 15, 2026 12:24
@alirezazolanvari

alirezazolanvari commented Aug 15, 2026

Copy link
Copy Markdown
Member Author

@alirezazolanvari

Thanks for your efforts. I had intended to approve and merge this pull request, but upon further review, I noticed that the target branch is set to main instead of dev. Please check it again and then ping me.

@sepandhaghighi thanks for the catch. It's fixed.

@sepandhaghighi sepandhaghighi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sepandhaghighi
sepandhaghighi merged commit f1c3a6a into dev Aug 16, 2026
27 checks passed
@sepandhaghighi
sepandhaghighi deleted the refactor-centralize branch August 16, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants