Refactor centralize - #52
Conversation
Not up to standards ⛔
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #52 +/- ##
==========================================
- Coverage 98.73% 98.69% -0.03%
==========================================
Files 9 9
Lines 235 229 -6
Branches 26 26
==========================================
- Hits 232 226 -6
Misses 2 2
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for your efforts. I had intended to approve and merge this pull request, but upon further review, I noticed that the target branch is set to |
@sepandhaghighi thanks for the catch. It's fixed. |
What does this implement/fix? Explain your changes.
_model_functionconverted to astaticmethodand now receives model parameters viaasdict