Feat/is holiday - #68
Open
sadrasabouri wants to merge 7 commits into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #68 +/- ##
==========================================
+ Coverage 97.25% 97.33% +0.08%
==========================================
Files 7 7
Lines 109 112 +3
Branches 25 25
==========================================
+ Hits 106 109 +3
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sadrasabouri
marked this pull request as ready for review
August 18, 2026 07:51
sepandhaghighi
requested changes
Aug 18, 2026
|
|
||
| ```pycon | ||
| >>> from rokh import is_holiday, DateSystem | ||
| >>> is_holiday(13, 1, 1450, DateSystem.JALALI, DateSystem.JALALI) |
Member
There was a problem hiding this comment.
>>> is_holiday(day=13, month=1, year=1450, event_date_system=DateSystem.JALALI)| ### Changed | ||
| - Dependencies structure modified | ||
| - Test system modified | ||
| - Jalali events updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#64
What does this implement/fix? Explain your changes.
Any other comments?