Add --pko flag to promote saas command#875
Add --pko flag to promote saas command#875dustman9000 wants to merge 1 commit intoopenshift:masterfrom
Conversation
Most operators now have both OLM and PKO SAAS files (e.g., saas-certman-operator.yaml and saas-certman-operator-pko.yaml). The --pko flag appends -pko to the serviceId so users can type the natural operator name instead of the full PKO file name.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe change adds a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dustman9000: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
--pkoflag toosdctl promote saasthat appends-pkoto the serviceIdsaas-certman-operator.yamlandsaas-certman-operator-pko.yaml)Usage
Test plan
osdctl promote saas --serviceId saas-aws-vpce-operator --pko --gitHash <hash>resolves tosaas-aws-vpce-operator-pkoosdctl promote saas --serviceId saas-aws-vpce-operator-pko --pkodoes not double-append-pkoosdctl promote saas --serviceId saas-aws-vpce-operator --gitHash <hash>still works without--pko(no regression)