Skip to content

Add --pko flag to promote saas command#875

Open
dustman9000 wants to merge 1 commit intoopenshift:masterfrom
dustman9000:pko-promote-flag
Open

Add --pko flag to promote saas command#875
dustman9000 wants to merge 1 commit intoopenshift:masterfrom
dustman9000:pko-promote-flag

Conversation

@dustman9000
Copy link
Copy Markdown
Member

Summary

  • Adds a --pko flag to osdctl promote saas that appends -pko to the serviceId
  • Most operators now have both OLM and PKO SAAS files (e.g., saas-certman-operator.yaml and saas-certman-operator-pko.yaml)
  • This lets users type the natural operator name instead of the full PKO file name

Usage

# Before: had to know the exact PKO file name
osdctl promote saas --serviceId saas-aws-vpce-operator-pko --gitHash abc123

# After: use --pko with the natural name
osdctl promote saas --serviceId saas-aws-vpce-operator --pko --gitHash abc123

Test plan

  • osdctl promote saas --serviceId saas-aws-vpce-operator --pko --gitHash <hash> resolves to saas-aws-vpce-operator-pko
  • osdctl promote saas --serviceId saas-aws-vpce-operator-pko --pko does not double-append -pko
  • osdctl promote saas --serviceId saas-aws-vpce-operator --gitHash <hash> still works without --pko (no regression)

Most operators now have both OLM and PKO SAAS files (e.g.,
saas-certman-operator.yaml and saas-certman-operator-pko.yaml).
The --pko flag appends -pko to the serviceId so users can type
the natural operator name instead of the full PKO file name.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d74162bd-e38d-43f3-b4f1-bddadf6fdec2

📥 Commits

Reviewing files that changed from the base of the PR and between 4e14680 and da06783.

📒 Files selected for processing (1)
  • cmd/promote/saas/saas.go

Walkthrough

The change adds a --pko CLI flag to the saas promote command. When enabled and the service ID doesn't already end with -pko, the flag automatically appends -pko to the service ID before service promotion logic executes.

Changes

Cohort / File(s) Summary
CLI Flag Enhancement
cmd/promote/saas/saas.go
Added --pko CLI flag and isPKO option to saasOptions. When promoting a service, the code conditionally appends -pko suffix to the service ID if not already present before retrieving the service.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from MateSaary and petrkotas April 9, 2026 15:16
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

@dustman9000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-docs da06783 link true /test verify-docs

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant