Debugging aws-ipi-confidential-fips-mini-perm profile#77758
Debugging aws-ipi-confidential-fips-mini-perm profile#77758melvinjoseph86 wants to merge 2 commits intoopenshift:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-confidential-fips-mini-perm-f7 |
|
@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 1 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request modifies a CI test configuration to update environment variables and test execution flow, while adding a delay in the corresponding test script. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 inconclusive)
✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: melvinjoseph86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml (1)
323-324: Set wait duration explicitly for this profile.Relying on
waitdefaults makes runtime harder to reason about. SetSLEEP_DURATIONinenvso intent is explicit and stable.💡 Suggested fix
env: AWS_INSTALL_USE_MINIMAL_PERMISSIONS: "yes" COMPUTE_CONFIDENTIAL_COMPUTE: AMDEncryptedVirtualizationNestedPaging COMPUTE_NODE_TYPE: m6a.2xlarge CONFIDENTIAL_COMPUTE: "" CONTROL_PLANE_CONFIDENTIAL_COMPUTE: AMDEncryptedVirtualizationNestedPaging CONTROL_PLANE_INSTANCE_TYPE: m6a.2xlarge FIPS_ENABLED: "true" TEST_SCENARIOS: "43284" + SLEEP_DURATION: "2h" test: - ref: wait - ref: openshift-extended-test🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml` around lines 323 - 324, This profile currently relies on the shared "wait" defaults; add an explicit SLEEP_DURATION environment variable in the profile's env block (e.g., add an env entry with name: SLEEP_DURATION and a chosen value like "5m" or the project-standard duration) so runtime wait is explicit and stable—update the profile's env section near the refs for wait/openshift-extended-test and ensure the new SLEEP_DURATION uses the same units/format as other SLEEP_DURATION usages in the repo.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/step-registry/openshift-extended/test/openshift-extended-test-commands.sh`:
- Line 247: The unconditional "sleep 5400" in
openshift-extended-test-commands.sh adds 90 minutes of fixed latency; change it
to be gated by an explicit debug env var (e.g., ENABLE_EXTENDED_TEST_SLEEP)
defaulting to off so normal consumers aren't delayed. Replace the bare sleep
5400 invocation with a conditional that only runs the sleep when the env var is
set to "true" (or a similar agreed token), and document the env var in the
script header or comments so consumers know how to enable it for debugging.
---
Nitpick comments:
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml`:
- Around line 323-324: This profile currently relies on the shared "wait"
defaults; add an explicit SLEEP_DURATION environment variable in the profile's
env block (e.g., add an env entry with name: SLEEP_DURATION and a chosen value
like "5m" or the project-standard duration) so runtime wait is explicit and
stable—update the profile's env section near the refs for
wait/openshift-extended-test and ensure the new SLEEP_DURATION uses the same
units/format as other SLEEP_DURATION usages in the repo.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 512fd065-c7a0-4658-8abe-877348e0f9b8
📒 Files selected for processing (2)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yamlci-operator/step-registry/openshift-extended/test/openshift-extended-test-commands.sh
| ;; | ||
| esac | ||
|
|
||
| sleep 5400 |
There was a problem hiding this comment.
Avoid unconditional 90-minute sleep in this shared step.
This adds fixed latency to every openshift-extended-test consumer and can significantly increase timeout/lease risk. Please gate it behind an explicit debug env var (default off) or remove it.
💡 Suggested fix
-sleep 5400
+if [[ "${DEBUG_SLEEP_SECONDS:-0}" =~ ^[0-9]+$ ]] && (( DEBUG_SLEEP_SECONDS > 0 )); then
+ echo "Debug sleep enabled: ${DEBUG_SLEEP_SECONDS}s"
+ sleep "${DEBUG_SLEEP_SECONDS}"
+fi📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| sleep 5400 | |
| if [[ "${DEBUG_SLEEP_SECONDS:-0}" =~ ^[0-9]+$ ]] && (( DEBUG_SLEEP_SECONDS > 0 )); then | |
| echo "Debug sleep enabled: ${DEBUG_SLEEP_SECONDS}s" | |
| sleep "${DEBUG_SLEEP_SECONDS}" | |
| fi |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/step-registry/openshift-extended/test/openshift-extended-test-commands.sh`
at line 247, The unconditional "sleep 5400" in
openshift-extended-test-commands.sh adds 90 minutes of fixed latency; change it
to be gated by an explicit debug env var (e.g., ENABLE_EXTENDED_TEST_SLEEP)
defaulting to off so normal consumers aren't delayed. Replace the bare sleep
5400 invocation with a conditional that only runs the sleep when the env var is
set to "true" (or a similar agreed token), and document the env var in the
script header or comments so consumers know how to enable it for debugging.
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-confidential-fips-mini-perm-f7 |
|
@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-confidential-fips-mini-perm-f7 |
|
@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-confidential-fips-mini-perm-f7 |
|
@melvinjoseph86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@melvinjoseph86: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary by CodeRabbit
Release Notes