Skip to content

[FEATURE] codereview功能如何实现? #555

Description

@muwoo

看文档上说可以实现codereview能力。但是有么有具体的demo可以简单介绍一下使用方式?
image

Activity

  1. self-assigned this
    on Mar 4, 2022
  2. hacke2 commented on Mar 4, 2022

    @hacke2
    Member

    CR 主要分三块:

    1. 使用 Tree API 实现变更树
    2. 如果是纯前端版注册一个处理 git 协议的 editorDocumentModelContentProvider 用了定义 git 协议如何打开,带容器的不需要,git 插件会注册
    3. 使用 comments api 给对应变更文件添加评论,也可以用模块的 api 做更多的拓展(例如给编辑器 decoration 上加当前评论者的头像、替换整个内置评论组件等)

    上面说的内容大部分逻辑写在了上层集成放里,目前还没下沉到 opensumi,我写个文档和最佳实践示例

  3. muwoo commented on Mar 4, 2022

    @muwoo
    Author

    @hacke2 感谢回复!非常期待这个功能的最佳实践示例。之前我也在蚂蚁用了你们的这个codereview,感觉很棒!现在我们也希望可以集成这个能力,目前来看文档稍微欠缺了点。持续关注中!感谢开源!

  4. stale commented on Oct 12, 2022

    @stale

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

  5. locked and limited conversation to collaborators on Oct 13, 2022
  6. converted this issue into a discussion #1783 on Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions