Repository navigation
Conversation
|
@tokainz is attempting to deploy a commit to the njevric's projects Team on Vercel. A member of the Team first needs to authorize it. |
41932c9 to
a31af90
Compare
|
Hi Tobias, thanks for taking the time to work on this! This fixes the issue. If you have time, I'd also love to see the same fix for the other components with overlays, like MultiSelect, AutoComplete, CascadeSelect and TreeSelect. Since this issue is only about Select, those could go in separate issues/PRs. Thanks again for taking the time! |
Done
Sure I will add the other PRs in the next few days. Thanks for looking at it! |
That was quick, thanks |
What does this PR do?
When a
Select, or another overlay component, is placed in theheaderorfooterslot ofDatePicker, picking an option closed the calendar overlay.The
Selectoverlay is appended tobody, so it sits outside the DatePicker overlay, and the DatePicker's outside-click listener treated themousedownon an option as an outside click.DatePicker now listens to overlay-click on the
OverlayEventBuswhile the overlay is open. When the emitting component lives inside the DatePicker overlay,selfClickis set and the outside-click listener ignores that click. This follows the existing pattern used byPopoverand the DataTableColumnFilter.Related issue
Closes #571
Checklist
pnpm run lintandpnpm run formatpass## [Unreleased]inCHANGELOG.md(skip for internal refactors, tests, CI, and docs typos)