fix(storage): add missing VirtioScsi resource_reference types#490
Open
RedZapdos123 wants to merge 1 commit into
Open
fix(storage): add missing VirtioScsi resource_reference types#490RedZapdos123 wants to merge 1 commit into
RedZapdos123 wants to merge 1 commit into
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
3380361 to
bcf6532
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue #489 reported that two Virtio SCSI resource reference fields were missing explicit
google.api.resource_referencetyping.VirtioScsiLun.target_name_refandStatsVirtioScsiLunRequest.controller_name_refreferenced other storage resources, but unlike nearby fields in the same proto they only declared field behavior. That left the schema inconsistent and omitted the concrete target resource metadata expected for resource-reference fields.This PR adds the missing resource reference annotations:
target_name_ref->opi_api.storage.v1/VirtioScsiTargetcontroller_name_ref->opi_api.storage.v1/VirtioScsiControllerIt also refreshes the checked-in generated Go and Python descriptor bindings for
frontend_virtio_scsi.proto, so the committed SDK artifacts now carry the same metadata as the source schema.Closes #489.
Checklist:
frontend_virtio_scsi.proto.buf lint --path storage/frontend_virtio_scsi.proto.api-linterchecks against Buf-built descriptor sets for bothmainand this PR version ofstorage/frontend_virtio_scsi.proto.api-linterresult is unchanged by this PR: both before and after report only the same pre-existingcore::0191::proto-packagefinding.Why the generated diff is large:
The functional change is small, but the checked-in generated files embed serialized protobuf descriptors. Adding two
resource_referenceoptions changes those descriptor blobs and their offsets, which shows up as a large textual diff in generated Go/Python output.Before the fix:
These fields had no explicit target resource typing.
After the fix:
The source schema and checked-in generated descriptors now carry the correct resource reference metadata.