Make ArchiveUtils work on Windows#683
Draft
ThomasVitale wants to merge 1 commit intooras-project:mainfrom
Draft
Conversation
* Handle POSIX permissions only on compatible OSes, with fallback on default, standard permissions. * Include check to ensure the OS support symlinks before creating them. On Windows, a warning is logged when trying to create a symlink without the necessary permissions. Fixes oras-projectgh-671 Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (65.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
============================================
+ Coverage 86.70% 87.10% +0.40%
- Complexity 943 944 +1
============================================
Files 43 43
Lines 2910 2923 +13
Branches 364 367 +3
============================================
+ Hits 2523 2546 +23
+ Misses 229 217 -12
- Partials 158 160 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes gh-671
Testing done
Confirmed the automated tests for ArchiveUtils still work on macOS and Linux. I'm still running some tests on Windows. After that, I'll move the PR from Draft to Ready-to-review.
Submitter checklist
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR