Repository navigation
xfstests: label a refused mount, read versions from the serial terminal - #53
Merged
Merged
Conversation
An xfstests run whose test device cannot be mounted prints, for every subtest, "mount.nfs: an incorrect mount option was specified for ..." and "common/rc: could not mount ... on ...". Those lines decide the case, and --errors showed none of them. The [mount] label takes its forms from upstream: - util-linux sys-utils/mount.c prints "mount: <target>: <reason>." with the reasons of libmount/src/context_mount.c. Its WARNING: lines and an "unknown filesystem type", which LTP and xfstests probe for and skip on, are left out, as are the status lines of mount -v and umount. - nfs-utils utils/mount/error.c: the mount_error, rpc_mount_errors and sys_mount_errors forms of mount.nfs. - xfstests common/rc: "could not mount" of init_rc and "failed to mount" of _require_test. It sits with the other tool labels, so the cap of 3 hits per label keeps hundreds of repeated lines to three.
…pload xfstests jobs on openqa.opensuse.org boot an image with xfstests already installed, so install.pm returns before collect_version and no job uploads version.log; the versions line said "not found" for the job and its last good run alike. partition.pm still prints /opt/version.log, the rpm -qa lines of the tools and the kernel and rpm -qi kernel-default, to the serial terminal, within its first 11 kB in the jobs checked. A job whose downloads tab lists no package list but serial_terminal.txt now has the first 256 KiB of it read with one ranged request and parsed as before; a line cut at the limit is dropped, as it could read as a shorter version. That is one more request per job without a list, two at most. Nothing more is read when a list was uploaded, and last good keeps its own list over the job's fallback. A suite missing from the serial terminal reads "?", as in a kernel-only list, since its head is no complete package list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oqa-log --errors now labels a refused mount (mount, mount.nfs and xfstests' could not mount), the decisive line of an NFS version that the kernel no longer supports. oqa-history takes the kernel and xfstests versions from the head of serial_terminal.txt when a job uploaded no package list, which is every o3 xfstests job.