Repository navigation
docs: sync with openQA drift (5c04ab0..caa99968f2) - #51
Merged
Merged
Conversation
openQA 3017ee4eae made `openqa-cli --retry` retry 408/429/500/502/503/504 and connection errors and honor `Retry-After`. The `upstream_compat` doc still said "only 502/503 or connection errors" with a flat 3 s delay, which misdescribes the profile it contrasts against. The conclusion is unchanged: it is not the `upstream_compat` profile.
Reviewed upstream Jobs/Constants.pm between 5c04ab0 and caa99968f2: no value or state-group change. The scheduler now cancels jobs scheduled longer than `max_job_scheduled_time` with `timeout_exceeded` instead of `obsoleted`, so `TimeoutExceeded` covers that case too. Pinned to the reviewed commit rather than master so the doc never claims parity with upstream changes that were not examined. `vectors.json` stays on 5c04ab0: the signing code did not change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compared the pinned openQA revision
5c04ab047ac9against upstreammaster(57b111c4, 222 commits ahead). No wire or behaviour divergence; auth signing (Auth.pm,REST.pm,UserAgent.pm,Client.pm,Config.pm) is unchanged apart from log-string quoting.src/policy.rs: theupstream_compatdoc describedopenqa-cli'sretry_txas retrying only 502/503. Since openQA3017ee4eaeit retries 408/429/500/502/503/504 and connection errors and honorsRetry-After.src/consts.rs: re-pinned to the reviewed commitcaa99968f2(not master, so no parity is claimed with unreviewed commits). That commit only changes a comment onTIMEOUT_EXCEEDEDand makes the scheduler use it for jobs scheduled longer thanmax_job_scheduled_time(previouslyobsoleted);TimeoutExceededis documented accordingly. No value or state-group change.tests/vectors.jsonprovenance stays on5c04ab0: the signing code did not change, so no re-derivation happened.Doc-comment changes only; no version bump (release-plz owns it).
Verified locally:
cargo fmt --check,cargo clippy --all-targets --locked -- -D warnings,cargo test --locked,cargo check --locked --all-targets,cargo docwith-D warnings.